Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in documentation files #2315

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maximevtush
Copy link

No description provided.

@maximevtush
Copy link
Author

@lnliz ready to merge?

@yyforyongyu
Copy link
Collaborator

Approved CI run, can you squash your commits.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13218870758

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 57.277%

Files with Coverage Reduction New Missed Lines %
mempool/mempool.go 1 66.67%
Totals Coverage Status
Change from base Build 12775873016: 0.02%
Covered Lines: 29952
Relevant Lines: 52293

💛 - Coveralls

@guggero
Copy link
Collaborator

guggero commented Feb 10, 2025

I'm highly suspicious of this user. They've got 503 repositories, all forks and in all of them they opened PRs to either update the license file or fix typos. And they've set their profile to private so one can't see that easily.
If this isn't a bot trying to get around the "don't run CI on first-time contributors" protection of GitHub, then I don't know. Also, they don't respond to these allegations: lightninglabs/lightning-terminal#957 (comment)
Which convinces me further it's just a bot and we shouldn't accept the PRs.
Just too much weird stuff going on on GitHub these days to risk potential supply chain attack preparations for a couple of trivial typo fixes IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants